You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Currently, setPath creates a new File object. If we already have a custom file object we should just call setPath on it, along with the other setup to update the subscriptions and send the event.
Just so I understand - why is this preferable to just calling setFile with a new instance of the same file class? Up until now, I had envisioned setPath(filePath) as being a convenient shorthand for setFile(new pathwatcher.File(filePath)). I'm open to changing that behavior though.
Just convenience I guess - for example, creating remote files in Nuclide requires a fair amount of dependencies. It's a bit roundabout to have to create a new file when File implementations are able to change their own paths without much of an issue. The current behavior also means that we've effectively had to "blacklist" TextEditor.setPath from the Nuclide codebase, which seems a little odd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hansonw
force-pushed
the
fb-hw-setpath
branch
from
Currently,
setPathcreates a newFileobject. If we already have a custom file object we should just callsetPathon it, along with the other setup to update the subscriptions and send the event.Contributed under CC0.